Explore switching the Gradle build to org.gradlex.java-module plugins#13324
Merged
koppor merged 148 commits intoJabRef:java-module-pluginsfrom Jun 24, 2025
Merged
Explore switching the Gradle build to org.gradlex.java-module plugins#13324koppor merged 148 commits intoJabRef:java-module-pluginsfrom
koppor merged 148 commits intoJabRef:java-module-pluginsfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
The problem with mac signing can be summarized as follows:
|
koppor
added
the
dev: no-bot-comments
Member
|
When manually executing Do we need to adapt the target names? I thought, they are automatically. There is also |
Member
|
As far as I understand, we can move directories |
Member
|
macOS JabKit has issues: |
|
@trag-bot didn't find any issues in the code! ✅✨ |
This was referenced Jun 24, 2025
This was referenced Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topics to explore/discuss and initial state of this PR:
Topic 1 Switch from "merging non-module Jars" to "patching non-module Jars". See more details here: gradlex-org/java-module-packaging#57 (comment). For now, I did as much as possible to get
jabgui:assembleMacos-14succeed locally. There may be too much modules in the result and it may not yet run.Topic 2 Make sure everything that needs to be configured can be configured in java-module-packaging. @koppor already discovered some missing options. I now discovered some more. I would like to make sure that we are confident that all issues are addressed, before I release the next version of that plugin. Until then, you can use the plugin from-source when exploring (see below).
Topic 2.1 I would like to support the app-signing on MacOS in the plugin. So that calling
jpackagedirectly in the CI pipeline is no longer necessary. I have not looked into that yet. If you have an idea what would be needed,Steps to test
jabrefpreviewbranch which contains all the new featuresMandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)